-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: Refine Progression Sidebar hover and active states #8206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refines the hover and active states for the Progression Sidebar to align with Figma design specifications instead of using custom styles.
- Refactored CSS class structure to separate progression and non-progression sidebar item styling
- Renamed
progressionIcon
tohexagonIcon
for consistency - Removed custom hover effects for progression items to match design system
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/ui-components/src/Containers/Sidebar/SidebarItem/index.tsx | Updated class name reference from progressionIcon to hexagonIcon |
packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css | Restructured CSS to separate progression and standard sidebar item styles, removing custom hover states for progression items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8206 +/- ##
==========================================
+ Coverage 76.62% 76.63% +0.01%
==========================================
Files 115 115
Lines 9614 9614
Branches 322 322
==========================================
+ Hits 7367 7368 +1
+ Misses 2246 2245 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Lighthouse Results
|
Description
As mentioned in this comment #8166 (comment) this PR aims to use the styles defined in Figma for the Progression Sidebar instead of the custom hover and active styles that were previously added
Validation
The Progression Sidebar and Sidebar should appear correctly in both the preview and Chromatic
Related Issues
Related to #8166, Fixes #8179